]> dgit.raspbian.org Git - gnome-shell.git/commit
appDisplay: Factor out shared code into BaseAppView
authorGeorges Basile Stavracas Neto <georges.stavracas@gmail.com>
Fri, 22 May 2020 16:20:40 +0000 (13:20 -0300)
committerGeorges Basile Stavracas Neto <georges.stavracas@gmail.com>
Thu, 18 Jun 2020 13:54:31 +0000 (10:54 -0300)
commitcff0752bcc339025025ee438fe6e59629b3fae93
tree10bc5f423aebc44aedd921b2557c1dc5f2f50ba9
parent45d8e11123581580eeb3662f4fa73760454eae98
appDisplay: Factor out shared code into BaseAppView

The two BaseAppView subclasses now share a lot in terms of
widgetry: they both have a scroll view, pagination dots, swipe
management, etc.

Move this shared code into BaseAppView. Notice, however, that
BaseAppView only creates the widgetry, but it doesn't add them
to any specific layout. FolderView arranges the widgetry in a
vertical box, while AppDisplay arranges it in a ShellStack.

Add a new 'orientation' parameter to BaseAppView and use it
to determine the orientation of the pagination dots, the swipe
tracker direction, and the scroll event handling.

It is worth noticing that the scroll event is a bit more
sophisticated now: when the orientation is horizontal, it
handles all directions since mice wheels usually only generate
up/down events.

https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/1271
js/ui/appDisplay.js